Re: [U-Boot] [PATCH v3] at91: add support for CDU9G25 board

Dear Jiri Prchal,

In message 1378991839-16732-1-git-send-email-jiri.prchal@aksignal.cz you wrote: ...

+err_spi_setup_slave:

• if (!is_valid_ether_addr(sernum)) {

• debug("Using random MAC address\n");
  

• eth_random_enetaddr(sernum);
  

• }

Pleas change this debug() into a puts() [or rather a printf() and also print the value.] The user is supposed to know when something goes badly wrong and random addresses get used, and what these are.

• eth_setenv_enetaddr("ethaddr", sernum);

NAK. Here you unconditionally overwrite the MAC address, even if one is already present in the environment. This must never be done. If the user defines an address, shis shall always be respected.

Thanks.

Best regards,

Wolfgang Denk