Re: [U-Boot] [PATCH 4/6] sf: Update read/write command macros

On Sun, Jan 19, 2014 at 2:06 AM, Marek Vasut marex@denx.de wrote:

On Saturday, January 18, 2014 at 09:06:31 PM, Jagannadha Sutradharudu Teki wrote:

...

• Used readable names for read/write command macros
• Added comments for the same

Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com Cc: Marek Vasut marex@denx.de Cc: Simon Glass sjg@chromium.org

Does this patch have any impact other than making the code harder to understand ? :-(

What's the rationale for making the code more cryptic ?

No issues I guess with the readability as each macro we can easily understand. like CMD_RD_QUAD --> command_read_quad CMD_WR_PAGE --> command_write_page_program

And this will minimize the macro length - good for in coding and more over description is added in drivers/mtd/spi/sf_internal.h anyway.