Dear Rob,
In message 4F566D05.5020809@gmail.com you wrote:
+3. Write value to environment if setup in struct eth_device->enetaddr by driver
- initialize() function. Give priority to the value in the environment if a
- conflict.
Sorry, but this description is not correct. You say here that the environment variable should always be written, but this is not the case. Only if it does not exist it shall be set. If it exists, it shall only be read, and in case of inconsistencies a warning shall be printed.
How about this:
- Always use the value in the environment if there is a conflict. If
the environment variable is not set and the driver initialized struct eth_device->enetaddr, then print a warning and set the environment variable to initialized by the driver.
I find you make it difficult to read without need by explaining it backwards.
The environment variable will be compared to the driver initialized struct eth_device->enetaddr. If they differ, a warning is printed, an the environment variable will be used unchanged.
If the environment variable is not set, it will be initialized from eth_device->enetaddr, and a warning will be printed.
Best regards,
Wolfgang Denk