28 Aug
2012
28 Aug
'12
1:05 p.m.
On 28/08/2012 10:47, Jeroen Hofstee wrote:
Hello Stefano,
Could we use here a define, something like this:
#define PANEL_TIMING_H(bp, fp, sw) (((bp - 1) << 20) | ((fp - 1) << 8) | (sw - 1))
Agree - and put it in a common header (arch/dss.h), making it accessible to all boards. And we need only one macro PANEL_TIMING, the register has the same layout.
I'll do in V2.
The hbp, hfp, hsw, vsw all have a "(program to value minus 1)." vbp and vfp don't, you can set those to zero.
So while the layout is the same, the meaning isn't. To make the values match the lcd specification, I would prefer to have the separate defines.
That's right - I will put two separate defines.
Regards, Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================