Hi,Detlev
2011/4/30 Detlev Zundel dzu@denx.de:
Hi Baidu,
Hi,Detlev
default: /* unknown */
- putLabeledWord("UNKOWN
COMPRESSION METHOD = ", jNode->compr);
- putLabeledWord("UNKNOWN
COMPRESSION METHOD = ", jNode->compr); put_fl_mem(jNode, pL->readbuf); return -1; break;
This typo change is not mentioned in the change log and really does not belong here. Please put it into a separate changeset.
This is just the typo error correction. Do you think we really need another patch?
A patch description should include _all_ changes. Either you also put that change into the patch description or you make a separate change. Doing changes not described in the commit log are a good sign to show that one does not care what one does.
Yes, you are right. Add all the description in the commit log. But please firstly make this principle be applied for all guys submiting patch. Not just to the people rarely summitint patch. Be fair.