On 4 Dec 2017, at 02:04, Kever Yang kever.yang@rock-chips.com wrote:
Philipp,
On 11/29/2017 03:49 AM, Dr. Philipp Tomsich wrote:
Kever,
This series causes build-breakage (even outside of the rockchip targets)... See https://travis-ci.org/ptomsich/u-boot-rockchip/builds/308522589 https://travis-ci.org/ptomsich/u-boot-rockchip/builds/308522589
I'm not understand this error, sometimes I also met this, which depends on the build system. The asm/arch is a link to asm/arch-rockchip which is dynamic generated by build system, is there a option to make sure the build system generate the link before build the c source? +drivers/reset/reset-rockchip.c:11:31: fatal error: asm/arch/hardware.h: No such file or directory
Please fix and resubmit. Also: did you test this using buildman or travis?
I use buildman, but no expperience with travis.
This reproduces with buildman for me. I wonder what difference in our setups causes this not to show up on your end… Also: why is reset-rockchip.o even being built for the evb-ast2500 target?
ptomsich@android:~/u-boot-rockchip$ tools/buildman/buildman arm11 Building current source for 11 boards (4 threads, 1 job per thread) arm: + evb-ast2500 +drivers/reset/reset-rockchip.c:11:31: fatal error: asm/arch/hardware.h: No such file or directory + #include <asm/arch/hardware.h> + ^ +compilation terminated. +make[3]: *** [drivers/reset/reset-rockchip.o] Error 1 +make[2]: *** [drivers/reset] Error 2 +make[1]: *** [drivers] Error 2 +make: *** [sub-make] Error 2 arm: + rpi +arch/arm/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0]) +arch/arm/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0]) +arch/arm/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0]) +arch/arm/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0]) +arch/arm/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0]) +arch/arm/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0]) +arch/arm/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0]) 9 1 1 /11 0:00:07 : mx31pdk
Thanks,
- Kever
Thanks, Philipp.
On 28 Nov 2017, at 11:06, Philipp Tomsich <philipp.tomsich@theobroma-systems.com mailto:philipp.tomsich@theobroma-systems.com> wrote:
From: Elaine Zhang <zhangqing@rock-chips.com mailto:zhangqing@rock-chips.com>
Create driver to support all Rockchip SoCs soft reset. Example of usage: i2c driver: ret = reset_get_by_name(dev, "i2c", &reset_ctl); if (ret) { error("reset_get_by_name() failed: %d\n", ret); }
reset_assert(&reset_ctl); udelay(50); reset_deassert(&reset_ctl);
i2c dts node: resets = <&cru SRST_P_I2C1>, <&cru SRST_I2C1>; reset-names = "p_i2c", "i2c";
Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com mailto:zhangqing@rock-chips.com> Signed-off-by: Kever Yang <kever.yang@rock-chips.com mailto:kever.yang@rock-chips.com> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com mailto:philipp.tomsich@theobroma-systems.com>
Changes in v2:
- fix Kconfig more than 80 length
- use MACRO for reset bits in one reg
- use rkclr/set_reg for reg access
- add rockchip_reset_bind()
- use dev_read_addr_size() instead of fdtdec_
drivers/reset/Kconfig | 9 +++ drivers/reset/Makefile | 1 + drivers/reset/reset-rockchip.c | 133 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 143 insertions(+) create mode 100644 drivers/reset/reset-rockchip.c
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com mailto:philipp.tomsich@theobroma-systems.com> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de mailto:U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot https://lists.denx.de/listinfo/u-boot