Re: [U-Boot] [PATCH RESEND] mpc85xx: Fix a compiler warning when CONFIG_WATCHDOG is turned on

Dear Horst Kronstorfer,

In message 1363175243-12183-1-git-send-email-hkronsto@frequentis.com you wrote:

cpu.c:288:2: warning: implicit declaration of function 'reset_85xx_watchdog' [-Wimplicit-function-declaration]

...

+void +watchdog_reset(void) +{

• int re_enable = disable_interrupts();
• reset_85xx_watchdog();
• if (re_enable) enable_interrupts();

+}

When changing code, please fix the formatting as needed. Here: please add a blank line after the declarations, and put the "enable_interrupts();" correctly indented on a new line.

And please start running your patches through checkpatch before submitting - it would have complained, too:

ERROR: trailing statements should be on next line #123: FILE: arch/powerpc/cpu/mpc85xx/cpu.c:298: + if (re_enable) enable_interrupts();

Thanks.

Best regards,

Wolfgang Denk