On Sun, Oct 25, 2015 at 4:53 AM, Jagan Teki jteki@openedev.com wrote:
Hi Febio,
On 24 October 2015 at 20:56, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Use the is_power_of_2() definition from log2.h to align with the kernel implementation.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com Reviewed-by: Tom Rini trini@konsulko.com
Changes since v1:
- None
arch/arm/mach-mvebu/mbus.c | 2 +- drivers/mtd/mtdcore.c | 2 +- drivers/mtd/ubi/build.c | 2 +- fs/ubifs/super.c | 2 +- include/linux/compat.h | 6 ------ 5 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/arch/arm/mach-mvebu/mbus.c b/arch/arm/mach-mvebu/mbus.c index 771cce6..346278e 100644 --- a/arch/arm/mach-mvebu/mbus.c +++ b/arch/arm/mach-mvebu/mbus.c @@ -52,7 +52,7 @@ #include <asm/io.h> #include <asm/arch/cpu.h> #include <asm/arch/soc.h> -#include <linux/compat.h> +#include <linux/log2.h>
I think we can place this header in to common.h like bitops.h does, because even Linux does same as bitops.h include<linux/kernel.h>
In this case this could be a separate patch then. My intention here was merely use the is_power_of_2() definition from log2.h instead of compat.h to align with the kernel implementation.
Feel free to submit your proposal as an incremental patch.
Regards,
Fabio Estevam