12 Mar
2013
12 Mar
'13
5:39 a.m.
Hi Heiko,
Do let me know if you have any comments on this patch. Would you consider it for I2C branch or should it go through u-boot-samsung?
Regards, Rajeshwari
On Wed, Mar 6, 2013 at 2:57 PM, Hung-ying Tyan tyanh@chromium.org wrote:
On Tue, Feb 19, 2013 at 8:19 PM, Rajeshwari Shinde <rajeshwari.s@samsung.com
wrote:
This patch corrects the following issues
- Write the correct M/T Stop value to I2CSTAT after i2c write. According to the spec, after finish the data transmission, we should write a M/T Stop (I2C_MODE_MT | I2C_TXRX_ENA) to I2CSTAT instead of a M/R Stop (I2C_MODE_MR | I2C_TXRX_ENA).
- Not split the write to I2CSTAT into 2 steps in i2c read. According to the spec, we should write the combined M/R Start value to I2CSTAT after setting the slave address to I2CDS
- Fix the mistake of making an equality check to an assignment. In the case of I2C write with the zero-length address, while tranfering
the data, it should be an equality check (==) instead of an assignment (=).
Signed-off-by: Tom Wai-Hong Tam waihong@chromium.org Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com
Tested-by: Hung-ying Tyan tyanh@chromium.org
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
--
Regards,
Rajeshwari Shinde