Hi Jernej,
On Tue, Apr 25, 2017 at 10:46:56PM +0200, Jernej Škrabec wrote:
Hi Maxime,
Dne torek, 25. april 2017 ob 10:57:05 CEST je Maxime Ripard napisal(a):
On Mon, Apr 24, 2017 at 11:54:22PM +0200, Jernej Škrabec wrote:
Hi Maxime,
Dne ponedeljek, 24. april 2017 ob 09:19:40 CEST je Maxime Ripard
napisal(a):
Hi Jernej,
On Fri, Apr 21, 2017 at 07:24:12PM +0200, Jernej Škrabec wrote:
Dne petek, 21. april 2017 ob 09:04:13 CEST je Maxime Ripard
napisal(a):
Hi Jernej,
On Mon, Mar 27, 2017 at 07:22:28PM +0200, Jernej Skrabec wrote: > This series implements support for HDMI output. This is done using > DM video framework and sharing the HDMI controller code with > RK3288. > > Patch 1 splits out TCON code which is completely reusable on > all Allwinner SoCs. > > Patch 2 converts common TCON code to use DM video compatible > timing > structure. > > Patch 3 adds all necessary clocks which are needed for Display > Engine 2, TCON and HDMI.
I merged all these patches...
> Patch 4 implement actual DE2 and HDMI driver and patch 5 disables > HDMI > on all boards which don't have it (default is on).
But not this one, since it creates a Kconfig warning due to the dependency of I2C_EDID on DM_I2C.
I think the current state of this discussion is that the i2c driver should be converted to the DM, which seems to be stalled at the moment.
Could you take in that patch and do the minor rework that were suggested by Simon so that we can get this in ?
Sorry I missed what was suggested by Simon?
You have the history there: https://patchwork.ozlabs.org/patch/734375/
Rework of this patch gives me a bit of a headache.
- Should I remove DM reset and clk calls since they are not yet supported by
sunxi? If so, where should clocks be enabled? In board config?
I'd say so, yes. This is not really nice, but this is just temporary, since we also have those patches being worked on at the moment.
- SPL code uses old I2C interface for setting regulators, so all code which
is called only in SPL but compiled also for U-Boot proper needs to be wrapped inside "#ifdef CONFIG_SPL_BUILD" or is there a better way? Example for that is drivers/power/sy8106a.c
I'm not aware of any way better than either having that ifdef, or having a separate Kconfig option, but that's pretty much the same thing.
- Even if we solve everything nicely, most boards don't have anything
attached to I2C besides power regulators, so I2C busses won't be probed anyway. This feels like a step back since you can't use i2c command unless device with available DM driver is defined in DT.
This isn't really an issue for me. All the relevant busses should be declared in the DT in the first place, so the fix for that one would be to simply add the bus and be done with it.
Maxime