Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090424200323.GD2953@game.jcrosoft.org you wrote:
What exactly do you mean by "move the STD API"?
In which way should the "STD API" be moved, and what exactly is the "STD API" you are referring to?
extract of arm init function
#if defined(CONFIG_DISPLAY_CPUINFO) print_cpuinfo, /* display cpu info (and speed) */ #endif #if defined(CONFIG_DISPLAY_BOARDINFO) checkboard, /* display board info */ #endif
I want we use the current API and not re-invent a new API for an arch only
Well, if you conside rthis the "standard API", this should (1) be documented somewhere, and (2) it must be fixed - at the moment, the code reads:
lib_arm/board.c:int print_cpuinfo (void); /* test-only */
I would not dare to use such a function in my code given the "test-only" comment.
And please, could you *please* be clear about what your comments mean
- I have no idea if your comment above means that you reject the
patch, or if you request it to be changed (in which case I don;t understand how it should be changed, or why), or if you are going to apply it.
Change requested
That's much better. Now at least we know where we are.
Thanks.
Best regards,
Wolfgang Denk