Dear Timur Tabi,
In message 1297808617-22396-1-git-send-email-timur@freescale.com you wrote:
Clean up the macro defintions used to enable DIU (video) support on the MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS, which is newer.
Signed-off-by: Timur Tabi timur@freescale.com
doc/README.mpc5121ads | 18 ++++++++++++++++++ doc/README.mpc8610hpcd | 7 +++++++ include/configs/MPC8610HPCD.h | 12 +++--------- include/configs/mpc5121ads.h | 8 +++----- 4 files changed, 31 insertions(+), 14 deletions(-) create mode 100644 doc/README.mpc5121ads
diff --git a/doc/README.mpc5121ads b/doc/README.mpc5121ads new file mode 100644 index 0000000..78fc3c9 --- /dev/null +++ b/doc/README.mpc5121ads @@ -0,0 +1,18 @@ +Freescale MPC5121ADS board +===========================
+Building U-Boot +---------------
- $ make mpc5121ads_config
- Configuring for mpc5121ads board...
- $ make
+Video Support +------------- +To enable DIU video support (console on a video display), define the macro +CONFIG_FSL_DIU_FB in the board header file (mpc5121ads.h) and set the +'monitor' environment variable appropriately.
Thanks - well meant, but wrong.
It makes little sense to add a README.board file which contains only commonplace like how to configure and build.
And CONFIG_* options must be explained in the top level README, not in some board files, and especially not repeatedly in all that might be affected. Such redundancy is always a Bad Thing.
Please drop these README.board files and move the documentation for CONFIG_FSL_DIU_FB into README.
Best regards,
Wolfgang Denk