Re: [U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c

Dear Michal Simek,

[...]

Would it be better just use this structure?

#ifdef CONFIG_SYS_NS16550_COM1 [0] = (NS16550_t)CONFIG_SYS_NS16550_COM1, #endif

[...]

You are using two coding styles in this file. One has function return value on one line and then function name and the second function return value on one line with function name. Will be good to unify it to look the same in the whole file.

Yes, wholeheartedly agree! But (!) I don't want to clean up this file in this patchset.

Thanks, Michal

Best regards, Marek Vasut