Re: [PATCH 3/4] dlmalloc: Fix integer overflow in sbrk()

On Tue, Aug 06, 2024 at 03:50:41PM -0600, Simon Glass wrote:

On Fri, 2 Aug 2024 at 04:08, Richard Weinberger richard@nod.at wrote:

...

Make sure that the new break is within mem_malloc_start and mem_malloc_end before making progress. ulong new = old + increment; can overflow for extremely large increment values and memset() can get wrongly called.

Signed-off-by: Richard Weinberger richard@nod.at

common/dlmalloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

Should we update dlmalloc to the new version?

A worthy but non-trivial goal, I think.