Dear Kevin,
In message 4B19905D.8040801@fearnside-systems.co.uk you wrote:
On 02/12/2009 22:09, Wolfgang Denk wrote:
Hi Kevin,
looking at the code resulting from commit 9ebfdc20 again, I see that you keep a LOT of uppercase variable names, which are not allowed as per coding style. DO you intend to convert these to proper lower-case names any time soon?
I can't see any variables with upper case names in the generic s3c24x0 code. The other arm920t code probably still has some but the s3c24x0 headers I patched only uses upper case names for constants and members of structs that map onto the CPU registers. For example:
Members of struct are just variables as well. They must use lower case names.
- u32 BWSCON;
- u32 BANKCON[8];
- u32 REFRESH;
- u32 BANKSIZE;
- u32 MRSRB6;
- u32 MRSRB7;
Right, all these need to be fixed.
Best regards,
Wolfgang Denk