On 11/4/2023 4:05 PM, Kumar, Udit wrote:
On 11/3/2023 6:07 AM, Nishanth Menon wrote:
Serdes initialization should be compile flag based instead of being eeprom based.
Signed-off-by: Nishanth Menon nm@ti.com
board/ti/j721e/evm.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index 17640ae79665..d49993fffe39 100644 --- a/board/ti/j721e/evm.c +++ b/board/ti/j721e/evm.c @@ -359,9 +359,6 @@ void configure_serdes_torrent(void) struct phy serdes; int ret; - if (!IS_ENABLED(CONFIG_PHY_CADENCE_TORRENT)) - return;
ret = uclass_get_device_by_driver(UCLASS_PHY, DM_DRIVER_GET(torrent_phy_provider), &dev); @@ -393,9 +390,6 @@ void configure_serdes_sierra(void) int ret, count, i; int link_count = 0; - if (!IS_ENABLED(CONFIG_PHY_CADENCE_SIERRA)) - return;
ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(sierra_phy_provider), &dev); @@ -477,10 +471,10 @@ int board_late_init(void) probe_daughtercards(); } - if (board_is_j7200_som()) + if (IS_ENABLED(CONFIG_PHY_CADENCE_TORRENT)) configure_serdes_torrent(); - if (board_is_j721e_som()) + if (IS_ENABLED(CONFIG_PHY_CADENCE_SIERRA)) configure_serdes_sierra();
Could be merged into one if condition
Please ignore above comments
with that
Reviewed-by: Udit Kumar u-kumar1@ti.com
return 0;