10 May
2008
10 May
'08
1:07 a.m.
In message 6514CE95-5C25-4C36-88DA-63E03DE87024@freescale.com you wrote:
TLB entries */ typedef enum { IBAT0 = 0, IBAT1, IBAT2, IBAT3, DBAT0, DBAT1, DBAT2, DBAT3 +#ifdef CONFIG_HIGH_BATS
- , IBAT4, IBAT5, IBAT6, IBAT7,
- DBAT4, DBAT5, DBAT6, DBAT7
+#endif
C allows trailing commas on such lists; no need to move it inside the ifdef.
Dangling commas bother me in the extreme. If this is the concensus, I'll move it, but I prefer it where it is.
Please move it. As is it looks irregular and ugly to me.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Q: What do you get when you cross an ethernet with an income statement?
A: A local area networth.