On 08/30/2011 08:47 AM, Albert ARIBAUD wrote:
Hi Stefano,
Hi Albert,
Building all versatile boards here with ELDK4.2 on a Natty Ubuntu, I get warnings of two sorts:
- in the QEMU build, you needlessly cast a pointer as 'volatile',
This is wrong...
which I missed on review but which my compiler does not like -- I did a general removal patch for code in U-Boot that calls get_ram_size() with a volatile-cast argument.
I saw the same issue rebuilding all IMX board for the scb9328 - because this was the only board with this warning I found, I sent a patch for it and I have already applied to u-boot-imx. I sent to you a "pull request", but let me know if you prefer I drop my patch from u-boot-imx before you merge into u-boot-arm.
- There are a lot of redefinitions, apparently a double include.
Can you look into this?
uboot@lilith:~/src/u-boot-arm$ ./MAKEALL versatileqemu versatilepb versatileab
Ok, that is clear. I tested only with qemu, because I have not the real board.
Configuring for versatileqemu - Board: versatile, Options: ARCH_VERSATILE_QEMU versatile.c: In function 'dram_init': versatile.c:98: warning: passing argument 1 of 'get_ram_size' discards qualifiers from pointer target type text data bss dec hex filename 100896 2140 12020 115056 1c170 ./u-boot Configuring for versatilepb - Board: versatile, Options: ARCH_VERSATILE_PB
Yes, it is redefined. I will send the patch, I will test the board running in the qemu environment.
Best regards, Stefano