Re: [U-Boot] [PATCH 2/2] ARM: highbank: remove DRAM bank setup

Dear Rob Herring,

In message 1359085160-28675-2-git-send-email-robherring2@gmail.com you wrote:

The memory sizes in highbank dtb's are already correct, so remove the DRAM bank setup so the memory node is not fixed up by u-boot.

I think you do more here...

-void dram_init_banksize(void) -{

• gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
• gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;

-}

...

-#define CONFIG_NR_DRAM_BANKS 1 +#define CONFIG_NR_DRAM_BANKS 0

I think this is a very bad idea, as you will now be no longer possible to get information about memory sizes from U-Boot. For exmaple, "bdinfo" will not print any reasonable value any more.

Please don't do that!

Best regards,

Wolfgang Denk