The module defines a duplicate uclass driver for UCLASS_SIMPLE_BUS, but it is not allowed. This breaks of-platdata and makes the result non-deterministic.
The driver does not need to be an uclass driver, so lets remove it. I had turned it into an uclass driver because I thought wrongly it had to call the dm_scan_fdt_dev routine to work properly, but some tests on the board have shown otherwise.
Signed-off-by: Dario Binacchi dariobin@libero.it
---
Changes in v2: - Remove UCLASS_SYSC id. - Change ti-sysc in a normal driver instead of an uclass driver. Previous tests, where I had removed the uclass driver, failed because I added the dm_scan_fdt_dev routine to the driver bind routine (I moved it from the uclass driver post_bind routine to the normal driver bind one).
drivers/bus/ti-sysc.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c index 4e3d610300..778c0654f6 100644 --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -148,12 +148,6 @@ clocks_err: return err; }
-UCLASS_DRIVER(ti_sysc) = { - .id = UCLASS_SIMPLE_BUS, - .name = "ti_sysc", - .post_bind = dm_scan_fdt_dev -}; - U_BOOT_DRIVER(ti_sysc) = { .name = "ti_sysc", .id = UCLASS_SIMPLE_BUS,