On Thu, Jan 09, 2025 at 08:01:17AM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 6 Jan 2025 at 14:41, Tom Rini trini@konsulko.com wrote:
On Mon, Jan 06, 2025 at 07:31:59AM -0700, Simon Glass wrote:
We want to encourage people to use an allocated bloblist since it is more flexible than a fixed one. Make this the default, being sure not to change existing users.
The unit tests require BLOBLIST_FIXED so add a dependency in the Makefile to avoid build errors.
Signed-off-by: Simon Glass sjg@chromium.org
[snip]
diff --git a/common/Kconfig b/common/Kconfig index e8d89bf6eb9..a00387a4609 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -1039,16 +1039,10 @@ if BLOBLIST
choice prompt "Bloblist location"
default BLOBLIST_FIXED if SANDBOX help Select the location of the bloblist, via various means.This should just be "default BLOBLIST_ALLOC" and sandbox platforms that are using the bloblist can be like the other platforms using a fixed address.
We don't need 'default BLOBLIST_ALLOC' as it is now first, so is the default. I would like the 'fixed' thing to be later on so that people know we want to stop using it.
All the sandbox platforms use BLOBLIST_FIXED. I'm not sure what change you are wanting me to make to this patch?
I'm wanting you to not re-order the list to change the default and instead use the default keyword to change the default.