Hi Tom,
On Mon, 31 Jan 2022 at 09:15, Tom Rini trini@konsulko.com wrote:
On Mon, Jan 31, 2022 at 09:13:02AM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 31 Jan 2022 at 07:24, Tom Rini trini@konsulko.com wrote:
On Sun, Jan 30, 2022 at 08:52:25AM -0700, Simon Glass wrote:
More than a year after this migration message appeared, we still have new boards being added with this option. Add a check against this.
Signed-off-by: Simon Glass sjg@chromium.org
Please just make this an error in checkpatch.pl instead.
I couldn't think of a way of doing that...do you have an idea?
Yes, 2f3e8d6a86cb ("checkpatch: report ERROR only on disabling of fdt and initrd relocation") updates the check I had for fdt_high/initrd_high being in the file at all to only be for additions. And yes, I check every PR for new checkpatch ERROR lines and only ignore the ones for code imported from other projects.
Yes, I understand that, but SPL_FIT_GENERATOR defaults to on for certain boards, so there is no need to mention it anywhere in the patch. Also someone could adjust the condition in the Kconfig to add other boards.
Regards, Simon