[U-Boot] [PATCH 1/7] phy: generic: add error trace to detect PHY issue in uclass

12 Nov 2019

Add an error trace for PHY errors directly in generic phy
functions provided by PHY uclass.
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
---
This patch is requested by Marek Vasut to avoid code duplication
in usb host serie for dwc2:
See http://patchwork.ozlabs.org/patch/1176048/#2297595
[U-Boot,RESEND,1/5] usb: host: dwc2: add phy support
drivers/phy/phy-uclass.c | 40 +++++++++++++++++++++++++++++++++++-----
 1 file changed, 35 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c
index e201a90c8c..363985b881 100644
--- a/drivers/phy/phy-uclass.c
+++ b/drivers/phy/phy-uclass.c
@@ -109,56 +109,86 @@ int generic_phy_get_by_name(struct udevice *dev, const char *phy_name,
 int generic_phy_init(struct phy *phy)
 {
    struct phy_ops const *ops;
+	int ret;
if (!phy)
    	return 0;
    ops = phy_dev_ops(phy->dev);
-	return ops->init ? ops->init(phy) : 0;
+	ret = ops->init ? ops->init(phy) : 0;
+	if (ret)
+		dev_err(phy->dev, "PHY: Failed to init %s: %d.\n",
+			phy->dev->name, ret);
+
+	return ret;
 }
int generic_phy_reset(struct phy *phy)
 {
    struct phy_ops const *ops;
+	int ret;
if (!phy)
    	return 0;
    ops = phy_dev_ops(phy->dev);
-	return ops->reset ? ops->reset(phy) : 0;
+	ret = ops->reset ? ops->reset(phy) : 0;
+	if (ret)
+		dev_err(phy->dev, "PHY: Failed to reset %s: %d.\n",
+			phy->dev->name, ret);
+
+	return ret;
 }
int generic_phy_exit(struct phy *phy)
 {
    struct phy_ops const *ops;
+	int ret;
if (!phy)
    	return 0;
    ops = phy_dev_ops(phy->dev);
-	return ops->exit ? ops->exit(phy) : 0;
+	ret = ops->exit ? ops->exit(phy) : 0;
+	if (ret)
+		dev_err(phy->dev, "PHY: Failed to exit %s: %d.\n",
+			phy->dev->name, ret);
+
+	return ret;
 }
int generic_phy_power_on(struct phy *phy)
 {
    struct phy_ops const *ops;
+	int ret;
if (!phy)
    	return 0;
    ops = phy_dev_ops(phy->dev);
-	return ops->power_on ? ops->power_on(phy) : 0;
+	ret = ops->power_on ? ops->power_on(phy) : 0;
+	if (ret)
+		dev_err(phy->dev, "PHY: Failed to power on %s: %d.\n",
+			phy->dev->name, ret);
+
+	return ret;
 }
int generic_phy_power_off(struct phy *phy)
 {
    struct phy_ops const *ops;
+	int ret;
if (!phy)
    	return 0;
    ops = phy_dev_ops(phy->dev);
-	return ops->power_off ? ops->power_off(phy) : 0;
+	ret = ops->power_off ? ops->power_off(phy) : 0;
+	if (ret)
+		dev_err(phy->dev, "PHY: Failed to power off %s: %d.\n",
+			phy->dev->name, ret);
+
+	return ret;
 }
UCLASS_DRIVER(phy) = {
-- 
2.17.1


    