________________________________________ From: Jean-Christophe PLAGNIOL-VILLARD [plagnioj@jcrosoft.com] Sent: Monday, May 18, 2009 5:25 PM To: Wolfgang Denk Cc: Paulraj, Sandeep; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] ARM DaVinci Leopard Board Support
On 22:47 Mon 18 May , Wolfgang Denk wrote:
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090518202149.GG17539@game.jcrosoft.org you wrote:
+#ifndef __CONFIG_H +#define __CONFIG_H +#include <asm/sizes.h>
+#define DAVINCI_LEOPARD
please CONFIG_
Or rather CONFIG_SYS_DAVINCI_LEOPARD
This is not a user-0selectable parameter, and such are fobidden outside the board config files anyway.
+#define CONFIG_SYS_NAND_SMALLPAGE +#define CONFIG_SYS_NAND_BASE_LIST { 0x02000000, }
please use macro
??? Please explain what you mean here. This is a macro, isn't it?
replase 0x02000000 by DAVINCI_ASYNC_EMIF_DATA_CE0_BASE
will do. depends on whether you accept another patch that i sent. That is required to include the hardware.h file
+/* U-Boot general configuration */ +#undef CONFIG_USE_IRQ /* No IRQ/FIQ in U-Boot */ +#define CONFIG_BOOTFILE "uImage" /* Boot file name */ +#define CONFIG_SYS_PROMPT "LEOPARD EVM # " +#define CONFIG_SYS_CBSIZE 1024 /* Console I/O Buffer Size */
why 1k?
Why not? That's a config option...
just ask to known why they need 1K? we have very long bootargs that can be passed to the video drivers
Best Regards, J.