Re: [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel

Hi Eric,

On Tue, Mar 26, 2013 at 12:24 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:

Since this convention is shared among at least SABRE Lite, SABRE SD, Nitrogen6x and Wandboard, wouldn't a weak function in imx-common/cpu.c be a better choice?

+#ifdef CONFIG_REVISION_TAG +u32 __weak get_board_rev(void) +{

•   return get_cpu_rev();
  

+} +#endif

Then boards could override things, but will do the reasonable thing without the extra code.

I like this idea. Will submit this change with the get_cpu_rev() tomorrow, after I get more comments on the proposed get_cpu_rev patch.

Thanks,

Fabio Estevam