Hello Fabio,
Am Donnerstag, den 01.07.2021, 08:24 -0300 schrieb Fabio Estevam:
Hi Teresa,
Your series looks great. Just a few comments on this patch.
thanks for your quick review.
On Thu, Jul 1, 2021 at 6:47 AM Teresa Remmet t.remmet@phytec.de wrote:
--- a/include/configs/phycore_imx8mp.h +++ b/include/configs/phycore_imx8mp.h @@ -42,6 +42,8 @@ "console=ttymxc0,115200\0" \ "fdt_addr=0x48000000\0" \ "fdt_file=" CONFIG_DEFAULT_FDT_FILE "\0" \
"ip_dyn=yes\0" \"serverip=192.168.3.10\0" \Please do not hardcode the "serverip" variable.
+/* ENET1 */ +#define CONFIG_ETHPRIME "FEC" +#define CONFIG_FEC_XCV_TYPE RGMII +#define CONFIG_FEC_MXC_PHYADDR 0 +#define FEC_QUIRK_ENET_MAC +#define IMX_FEC_BASE 0x30BE0000
As DM is being used these definitions can be removed. Please test without them.
Yes, works without the defines. Will send a v2 with the requested changes.
Thanks, Teresa