Re: [PATCH 5/6] net: add MV88E61xx DSA driver

On Tue, 29 Mar 2022 15:52:39 -0700 Tim Harvey tharvey@gateworks.com wrote:

Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches.

Signed-off-by: Tim Harvey tharvey@gateworks.com

Is this final version that should be accepted?

The drivers seems to support not only 61xx, but 6xxx (6096, 6250, 6352, ...).

Also there are some commented lines, for example

+// u16 port_stat_link_mask;/* Bitmask for port link status bits */ +// u16 port_stat_dup_mask; /* Bitmask for port duplex status bits */ +// u8 port_stat_speed_width;/* Width of speed status bitfield */

What is their purpose?

Why is mv88e61xx_dsa_xmit() no-op?

Marek