Hi,
On 18.7.2018 20:14, Luis Araneda wrote:
Hi Michal,
On Wed, Jul 18, 2018 at 9:22 AM Michal Simek michal.simek@xilinx.com wrote:
I was playing with this a little bit. There is no reason to allocate any space in malloc area because its/fit should already contain load address which you should use instead.
I initially thought the same, but unfortunately the load address is not a parameter passed to the function, nor can it be extracted from the spl_load_info structure. Like you have probably discovered by now, the spl_load_fpga_image() function was introduced to support the use case of boards with uninitialized DRAM, so the load address was not necessary. On the other hand, the zynpl driver doesn't have functions to program the FPGA by chunks, so I had to allocate memory.
Feel free to join that thread with Marek. I think that what we have in u-boot source code is not correct and it is one ugly hack which has no user and nothing is broken because support hasn't been merged to mainline. I have played with that yesterday and send this patch which should be enough for you to go. https://lists.denx.de/pipermail/u-boot/2018-July/335169.html
Also on zc706 without FULL_FIT my path in spl_load_fit_image is not jumping to "if (external_data) {" branch where spl_load_fpga_image is which is kind of interesting because it looks like you are going there.
Thanks, Michal