14 Oct
2011
14 Oct
'11
11 p.m.
Dear Marek Vasut,
In message 201110140959.42368.marek.vasut@gmail.com you wrote:
Running checkpatch on your patches I see a lot of issues, and not only a couple of them.
For example,
WARNING: line over 80 characters #632: FILE: arch/arm/cpu/arm926ejs/mx28/mx28.c:150: +int do_mx28_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
those iomux-mx28.h issues were already explained. It's a file taken from linux kernel with no modifications, that's why the issues. And if you take a look inside, fixing it would make it unreadable.
The error above appears to be unrelated. Why did you not fix at least these?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Where people stand is not as important as which way they face.
- Terry Pratchett & Stephen Briggs, _The Discworld Companion_