31 Aug
2011
31 Aug
'11
10:01 p.m.
On Wednesday, August 31, 2011 09:26:27 PM Mike Frysinger wrote:
On Tuesday, August 30, 2011 08:05:18 Michal Simek wrote:
- volatile struct temac_reg *regs = priv->regs;
- regs->lsw = (phy_addr << 5) | reg_addr;
- regs->ctl = MIIMAI | (emac << 10);
you should still be going through read/write i/o helper funcs rather than relying on the volatile markings
Oh, I didn't comment on the TEMAC. I'll have to go through it.
Cheers
the rest looks sane -mike