Re: [U-Boot] [PATCH v3 12/14] pico-imx6ul: Remove CONFIG_FSL_USDHC from .h

On Thu, Sep 13, 2018 at 6:49 PM Fabio Estevam festevam@gmail.com wrote:

On Thu, Sep 13, 2018 at 6:33 PM, Otavio Salvador otavio.salvador@ossystems.com.br wrote:

...

On Thu, Sep 13, 2018 at 5:14 PM Fabio Estevam festevam@gmail.com wrote:

...

...

...

I see that CONFIG_FSL_USDHC is defined inside "mx6_common.h", which is already included in this file, so the change looks good, but the commit message needs to be reworked.

Like:

pico-imx6ul: Remove CONFIG_FSL_USDHC from .h

The CONFIG_FSL_USDHC is defined inside "mx6_common.h", which is already included in this file.

Signed-off-by: Otavio Salvador otavio@ossystems.com.br

Yes, this looks good.

You can also add:

Reviewed-by: Fabio Estevam festevam@gmail.com

I will wait until tomorrow to send v4.