
Dear David,
in message 200308042135.48979.david@avoncliff.com you wrote:
I may have been making problems for myself.. but first when I put -Werror back in there was a problem in cmd_eeprom.c
Index: common/cmd_eeprom.c
RCS file: /cvsroot//u-boot/u-boot/common/cmd_eeprom.c,v retrieving revision 1.5 diff -u -r1.5 cmd_eeprom.c --- common/cmd_eeprom.c 1 Jul 2003 21:07:07 -0000 1.5 +++ common/cmd_eeprom.c 4 Aug 2003 23:04:04 -0000 @@ -36,6 +36,11 @@ uchar *buffer, unsigned cnt); #endif
+#ifdef CONFIG_SPI +extern ssize_t spi_read(uchar *addr, int alen, uchar *buffer, int len); +extern ssize_t spi_write (uchar *, int, uchar *, int); +extern void spi_init_f (void); +#endif
No, this is not a good idea. The right place to fix this is in "include/common.h" (by replacing "defined(CONFIG_PCU_E) || defined(CONFIG_CCM) || defined(CONFIG_ATC)" with "defined(CONFIG_SPI)".
#if defined(CFG_EEPROM_X40430) /* Maximum number of times to poll for acknowledge after write */
This may well not be the correct fix, but it allowed me to continue with done:; problem
Index: board/sc520_cdp/flash.c
RCS file: /cvsroot//u-boot/u-boot/board/sc520_cdp/flash.c,v retrieving revision 1.4 diff -u -r1.4 flash.c --- board/sc520_cdp/flash.c 27 Jun 2003 21:32:24 -0000 1.4 +++ board/sc520_cdp/flash.c 4 Aug 2003 23:23:27 -0000 @@ -325,7 +325,7 @@ } printf ("\n");
done:
done:;
Thanks, added.
Will push to CVS soon.
Best regards,
Wolfgang Denk