-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/17/12 02:55, Ilya Yanok wrote:
Hi Joe,
On Thu, Aug 30, 2012 at 1:25 AM, Joe Hershberger <joe.hershberger@gmail.com mailto:joe.hershberger@gmail.com> wrote:
[snip]
diff --git a/net/net.c b/net/net.c index e8ff066..bbd1a6d 100644 --- a/net/net.c +++ b/net/net.c @@ -81,6 +81,19 @@
#include <common.h> +#ifdef CONFIG_SPL_BUILD +/* SPL needs only BOOTP + TFTP so undefine other stuff to save
space */
+#undef CONFIG_CMD_DHCP +#undef CONFIG_CMD_CDP +#undef CONFIG_CMD_DNS +#undef CONFIG_CMD_LINK_LOCAL +#undef CONFIG_CMD_NFS +#undef CONFIG_CMD_PING +#undef CONFIG_CMD_RARP +#undef CONFIG_CMD_SNTP +#undef CONFIG_CMD_TFTPPUT +#undef CONFIG_CMD_TFTPSRV +#endif
Is this the best place to do this? Seems it would be clearer to modify config_cmd_default.h or add a config_cmd_spl.h that will undefine them, and include that.
I agree it's not the best place... config_cmd_spl.h sounds a little bit crazy as we don't have any commands at all in SPL...
How about config_uncmd_spl.h then and a nice big comment up top explaining what we're doing. Or can we take another stab at seeing why some stuff isn't being garbage collected? If garbage_collected_func_a calls never_seen_while_linking_func, we still succeed since we garbage collect the first func. There's just the gcc issue I've noted before about strings.
- -- Tom