On 01/20/2011 10:52 AM, Wolfgang Denk wrote:
Dear Stefano Babic,
In message 1295513194-16158-1-git-send-email-sbabic@denx.de you wrote:
Patchset V2 contain patches for SPI sent previously independently to ML and additional patches for I2C.
I just learned that I was running an old version of checkpatch, which turned out some false positives (and my short visual inspection did not recognize this)
Sorry for the flase alarms.
No problem, this explains the the different results. I ran checkpatch on the patchset.
The remaining warnings are:
[U-Boot] [PATCH V2 01/11] Add support for MX35 processor total: 0 errors, 8 warnings, 2109 lines checked
They are related to typedef (mmmhh...there is one regarding usage of volatile, I will fix it). I do not think that using typedef is forbidden.
[U-Boot] [PATCH V2 04/11] I2C: mxc_i2c: get rid of __REG access total: 0 errors, 2 warnings, 169 lines checked
__FUNCTION__, I will fix it
[U-Boot] [PATCH V2 05/11] I2C: mxc_i2c: address failure with mx35 total: 1 errors, 1 warnings, 166 lines checked
See my previous comment. In any case, I will change to avoid checkpatch complains
[U-Boot] [PATCH V2 08/11] SPI: mxc_spi: fix swapping bug and add total: 0 errors, 1 warnings, 22 lines checked
Braces, braces...do you agree to follow checkpatch's rule (no braces for single statement) ?
[U-Boot] [PATCH V2 11/11] Add support for Freescale's mx35pdk board. total: 0 errors, 1 warnings, 1331 lines checked
You already give me the solution
Best regards, Stefano Babic