Hi Bin,
On Tue, 30 Jun 2020 at 00:43, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Mon, Jun 15, 2020 at 11:58 AM Simon Glass sjg@chromium.org wrote:
At present the itss is probed in the ofdata_to_platdata() method. This is incorrect since itss is a child of p2sb which itself needs to probe the pinctrl device. This means that p2sb is effectively not probed when the itss is probed, so we get the wrong register address from p2sb.
I wonder how this ever worked?
I think it worked before the change to separate ofdata_to_platdata() and probe() properly, and also if the p2sb has already been probed for a different reason.
Fix this by moving the itss probe to the correct place.
Signed-off-by: Simon Glass sjg@chromium.org
drivers/pinctrl/intel/pinctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
Regards, Bin
Regards, Simon