Re: [PATCH 1/4] fs: btrfs: inode: handle uninitialized type before returning it

On Sat, Oct 31, 2020 at 09:07:49AM +0800, Qu Wenruo wrote:

In btrfs_lookup_path() the local variable @type should always be updated after we hit any file/dir.

But if @filename is NULL from the very beginning, then we don't initialize it and return it directly.

To prevent such problem from happening, we initialize @type to BTRFS_FT_UNKNOWN. For normal execution route, it will get updated for each filename we resolved. Buf if we didn't find any path, we check if the type is still FT_UNKNOWN and ret == 0. If true we know there is something wrong, just return -EUCLEAN to inform the caller.

Reported-by: Coverity CID 312958 Signed-off-by: Qu Wenruo wqu@suse.com Reviewed-by: Marek Behún marek.behun@nic.cz

Applied to u-boot/master, thanks!