Re: [U-Boot-Users] [PATCH 1/5][RESEND] CSB637 - add KB920x support

Anders,

--- /dev/null +++ b/board/kb9202/kb9202.c

...

+void lowlevel_init(void) {

• /* Required by assembly functions - do nothing */

+}

Why is this required?

--- a/cpu/arm920t/at91rm9200/i2c.c +++ b/cpu/arm920t/at91rm9200/i2c.c

...

+#ifdef CONFIG_KB920x

• twi->TWI_IADR = addr;

+#else /* Set TWI Internal Address Register with first messages data field */ /* only one address byte is supported */ if (alen > 0) twi->TWI_IADR = addr & 0xff; +#endif

Why is this required? IMHO we should avoid putting board dependend DEFINES in common code.

-- Steven