5 Nov
2011
5 Nov
'11
5:40 p.m.
Dear Gerlando Falauto,
In message 1319647072-17504-4-git-send-email-gerlando.falauto@keymile.com you wrote:
Signed-off-by: Gerlando Falauto gerlando.falauto@keymile.com
README | 2 ++ common/cmd_nvedit.c | 42 ++++++++++++++++++++++++++++++++++++------ common/env_common.c | 14 ++++++++++++++ include/config_cmd_all.h | 1 + include/environment.h | 5 +++++ 5 files changed, 58 insertions(+), 6 deletions(-)
Did you actually ever try to compile your code, and test it?
...
+#if CONFIG_CMD_DEFAULTENV_VARS
When I try and enable your code by adding
#define CONFIG_CMD_DEFAULTENV_VARS
to a board config file, this will result in a an error:
cmd_nvedit.c:699:31: error: #if with no expression
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Copy from one, it's plagiarism; copy from two, it's research.