Dear Simon,
In message 4E563136.2030608@gmail.com you wrote:
A question ex ante: what is the "bp" in "savebp" supposed to mean? I
...
It means "save boot parameters" - better proposals welcome.
If it's not too much of trouble I would indeed ask you to change that name.
Dismissing ecological considerations (should we save BP?), the ntroduction of such a command name would break a number of boards which use "save" as abbreviation for "saveenv" in their default configurations:
FPS850L M5253DEMO M5329EVB M5475EVB TQM850L TQM860M FPS860L M5271EVB M5373EVB M5485EVB TQM850M TQM862L M5208EVBE M5272C3 M54451EVB NSCU TQM855L TQM862M M52277EVB M5275EVB M54451EVB TQM823L TQM855M TQM866M M52277EVB M5282EVB M54455EVB TQM823M TQM860L virtlab2 M5235EVB M53017EVB M54455EVB
Yes, it has always been a bad idea to use abbreviated command names in environment settings, but it's being done again and again (myself not being immune to that temptation).
So please let's use a different name, one that does not start with "save".
Also, I think we should try and make the approach a bit more generic. Your current implementation supports only NAND as storage. But what if we want to do the same when booting from SDCard?
Maybe we should split the steps of extracting the FDT and ATAGS images and the process of actually writing them to persistent storage in two separate steps - for the second step we can then use existing standard commands, so only the "export" step is needed.
As all this is about preparing for a SPL boot, I suggest we name the new command "spl"; the resulting user interface could be like this:
spl export <img> addr [args ...]
with "img" being either "fdt" or "atags". [This would allow to add other SPL related commands easily in case we should need them.
What do you think?
Best regards,
Wolfgang Denk