Hello Christian,
Christian Riesch wrote:
This patch adds support for the Calimain board from OMICRON electronics GmbH. The board features a Texas Instruments AM1808 SoC, 128 MB DDR2 memory, and 64 MB NOR flash memory connected to CS2 and CS3.
Signed-off-by: Christian Riesch christian.riesch@omicron.at
MAINTAINERS | 5 + board/omicron/calimain/Makefile | 45 +++++ board/omicron/calimain/calimain.c | 201 ++++++++++++++++++++ boards.cfg | 1 + include/configs/calimain.h | 364 +++++++++++++++++++++++++++++++++++++ 5 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 board/omicron/calimain/Makefile create mode 100644 board/omicron/calimain/calimain.c create mode 100644 include/configs/calimain.h
just one comment, see below
[...]
diff --git a/board/omicron/calimain/calimain.c b/board/omicron/calimain/calimain.c new file mode 100644 index 0000000..b2f2d96 --- /dev/null +++ b/board/omicron/calimain/calimain.c @@ -0,0 +1,201 @@
[...]
+int board_early_init_f(void) +{
- /*
* Power on required peripherals* ARM does not have access by default to PSC0 and PSC1* assuming here that the DSP bootloader has set the IOPU* such that PSC access is available to ARM*/- if (da8xx_configure_lpsc_items(lpsc, ARRAY_SIZE(lpsc)))
return 1;- return 0;
+}
Please look at my comment to the patch from Sughosh here:
http://lists.denx.de/pipermail/u-boot/2012-January/115312.html
da8xx_configure_lpsc_items() should used in arch/arm/cpu/arm926ejs/davinci/da850_lowlevel.c
so you can remove this here ... Maybe you can have a look at this patch too?
Rest looks good to me, thanks!
bye, Heiko