On Wednesday 23 September 2009 19:51:24 Niklaus Giger wrote:
Adds a HCU5 board specific cmd reghcu5 to dump about 140 internal register which define the HW configuration. Needed for documentation purposes and to compare different settings.
Apart from Peter's comments, I also have a more general comment. Please correct me if I'm wring, but this register dump doesn't seem to be HCU5 specific, but PPC440EPx specific. If this is the case, we (you) should probably move this code into the cpu/ppc4xx directory. Perhaps something like:
cpu/ppc4xx/440epx_regdump.c
What do you think?
I feel honoured if you consider this patch useful for other boards, too. I will rename the cmd to "440epx_regdump" unless you have a better idea.
Thinking a bit more about it, we should probably choose a more generic name, so that other 4xx variants may use this command as well. How about just using "regdump"?
And please base you patch against the "4xx-register-cleanup" branch of my u- boot-ppc4xx repo.
Cheers, Stefan
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de