Re: [PATCH v2] cmd: setexpr: fix no matching string in gsub return empty value

On Thu, Feb 08, 2024 at 03:58:27PM +0100, Massimiliano Minella wrote:

From: Massimiliano Minella massimiliano.minella@se.com

In gsub, when the destination string is empty, the string 't' is provided and the regular expression doesn't match, then the final result is an empty string.

Example:

=> echo ${foo}

=> setenv foo => setexpr foo gsub e a bar => echo ${foo}

=>

The variable ${foo} should contain "bar" and the lack of match shouldn't be considered an error.

This patch fixes the erroneous behavior by removing the return statement and breaking out of the loop in case of lack of match.

Also add a test for the no match case.

Signed-off-by: Massimiliano Minella massimiliano.minella@se.com

Applied to u-boot/next, thanks!