Hi Stefan,
On Thursday 19 March 2009, Michael Lawnick wrote:
On systems where U-Boot is linked to another address than it really lays (e.g. backup image), calls via function pointers must be fixed with a '+= gd->reloc_off'. This was not done for none_compr in ubifs_compressors_init() what leads to system crash on ubifsmount command.
Signed-off-by: Michael Lawnick ml.lawnick@gmx.de
Acked-by: Stefan Roese sr@denx.de
Please note that I explicitly didn't fold this patch into my latest UBIFS patch series. We should apply it after UBIFS is available in mainline so that Michael will be listed as author for this fix.
I was not so sure about this, so I was waiting for your opinion, but are you sure that it is ok to remove the assignment? Doesn't other code depend on that?
@@ -147,7 +147,10 @@ int __init ubifs_compressors_init(void) if (err) return err;
- ubifs_compressors[UBIFS_COMPR_NONE] = &none_compr; + err = compr_init(&none_compr); + if (err) + return err; + return 0; }
Cheers Detlev