Hi Marcel,
On 16 August 2015 at 15:34, Marcel Ziswiler marcel@ziswiler.com wrote:
On Sun, 2015-08-16 at 15:26 -0600, Simon Glass wrote:
Says who? I was only aware that common.h needs to go on top, the local stuff (e.g. in double quotes) on the bottom and the rest I assumed can go alphabetically ordered in between, not?
I originally got it from here (and another thread I can't find):
http://lists.denx.de/pipermail/u-boot/2012-January/114965.html
Hm, interesting. But that one suggests a different order yet again. Unfortunately it misses giving any reason for any of this. Me seriously wondering now.
BTW: Marek was happy with my order of things for the PXA stuff:
http://git.denx.de/?p=u-boot/u-boot-pxa.git;a=commitdiff;h=940ed38dd673 ecfbe03ed5e36c25bc4238356947
The nice thing about sorting things in groups is that you can see at a glance what is missing. It doesn't make sense to have:
<asm/aaa.h> <bbb.c> <asm/ccc.h>
since the asm/ includes are quite a different category.
Regards, Simon