On Wednesday 31 December 2008 04:23:53 kenneth johansson wrote:
On Tue, 2008-12-30 at 23:14 +0100, Wolfgang Denk wrote:
Dear kenneth johansson,
In message 1230636057.17914.5.camel@duo you wrote:
Only print out the target name during make. For old style set V=1
What is the rationale for this patch? I can see no real advantage with it.
To highlight warnings during build. It's just a way to make the default output less noise.
If you find the make output annoying, you can silence make by passing the "-s" flag.
-s is a bit to much you get no feedback at all.
you may want to include this kind of "usage" in the changelog
with errors I guess you mean non optimal output. the patch really should not have any impact on the binaries built. If it really breaks the build that is a real problem and one I do not see in my test.
i dont really like how the changes are integrated. it'll require constant maintenance to add these QUIET prefix vars. is there a reason we cant go the opposite direction and set CC/etc... directly ? or try unifying things with patterns ?
i.e. drop all of the $(AR) calls in board/*/Makefile and replace it with a toplevel pattern kind of like: %.a: %.o $(AR) $(ARFLAGS) $^ -o $@ -mike