On Tuesday 08 March 2016 05:06 AM, Tom Rini wrote:
On Sat, Mar 05, 2016 at 05:33:39PM +0530, Lokesh Vutla wrote:
There are certain EMIF timing failures seen on the some x15 boards. Updating the EMIF settings to get rid of these timing failures.
Signed-off-by: Lokesh Vutla lokeshvutla@ti.com
Reviewed-by: Tom Rini trini@konsulko.com
But minor nit:
board/ti/am57xx/board.c | 136 +++++++++++++++++++++++------------------------- 1 file changed, 65 insertions(+), 71 deletions(-)
diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index d712ab0..9a8ee00 100644 --- a/board/ti/am57xx/board.c +++ b/board/ti/am57xx/board.c @@ -64,22 +64,22 @@ void emif_get_dmm_regs(const struct dmm_lisa_map_regs **dmm_lisa_regs) static const struct emif_regs beagle_x15_emif1_ddr3_532mhz_emif_regs = { .sdram_config_init = 0x61851b32, .sdram_config = 0x61851b32,
- .sdram_config2 = 0x00000000,
- .sdram_config2 = 0x8000000,
Here and in the other spot too, this hurts readability to me, it should be 0x08000000
Sure, Ill update and resend.
Thanks and regards, Lokesh