Re: [U-Boot] [PATCH] post, arm, memorytest: add support for arm based boards

Hello Mike,

Mike Frysinger wrote:

On Thursday, June 02, 2011 01:53:42 Heiko Schocher wrote:

...

Mike Frysinger wrote:

...

so add bi_memsize to arm ? it's the only arch that lacks it.

Hmm.. I thought of that too, but wouldn;t it be better to use gd->ram_size in post/drivers/memory.c, as this is defined in global_data for all archs?

makes me wonder why we have bd->bi_memsize in the first place.

and how can this possibly work ? arch/arm/lib/board.c: sprintf ((char *)memsz, "%ldk", (bd->bi_memsize / 1024) - pram); -mike

Yep, good question ... maybe, no arm based board has defined

"#if defined(CONFIG_PRAM) || defined(CONFIG_LOGBUFFER)"

?

I can make a fix and change this to gd->ram_size?

bye, Heiko