On Thu, Aug 17, 2023 at 10:46:14AM +0200, Quentin Schulz wrote:
Hi Jonas,
On 8/17/23 08:04, Jonas Karlman wrote:
Update MAINTAINERS files for RK3566/RK3568/RK3588 boards to include related device tree files. Also replace space with tabs.
Signed-off-by: Jonas Karlman jonas@kwiboo.se
board/anbernic/rgxx3_rk3566/MAINTAINERS | 3 ++ .../neural-compute-module-6/MAINTAINERS | 6 +++ board/radxa/rock5a-rk3588s/MAINTAINERS | 2 + board/radxa/rock5b-rk3588/MAINTAINERS | 4 +- board/rockchip/evb_rk3568/MAINTAINERS | 51 ++++++++++--------- board/rockchip/evb_rk3588/MAINTAINERS | 3 +- 6 files changed, 43 insertions(+), 26 deletions(-)
diff --git a/board/anbernic/rgxx3_rk3566/MAINTAINERS b/board/anbernic/rgxx3_rk3566/MAINTAINERS index 1c0d3fe7b5bf..6be16a47e8eb 100644 --- a/board/anbernic/rgxx3_rk3566/MAINTAINERS +++ b/board/anbernic/rgxx3_rk3566/MAINTAINERS @@ -4,3 +4,6 @@ S: Maintained F: board/anbernic/rgxx3_rk3566 F: include/configs/anbernic-rgxx3-rk3566.h F: configs/anbernic-rgxx3_defconfig +F: arch/arm/dts/rk3566-anbernic-rgxx3.dts +F: arch/arm/dts/rk3566-anbernic-rgxx3.dtsi +F: arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi
An easier way to deal with this is to use the "*" character since it's supported in MAINTAINERS file apparently (ag -Q "*" **/MAINTAINERS returns multiple matches in multiple files). So maybe replace it with something like
F: arch/arm/dts/rk3566-anbernic-rgxx3*
?
That way if the files eventually get split into multiple ones, get renamed, have one created (e.g. -u-boot.dtsi), they are all matched by that same line. Less maintenance here (and hopefully precise enough that we don't have false positives).
Just a suggestion,
Using the "N:" syntax might be better-still, since you could do: N: anbernic-rgxx3 And that covers anything with anbernic-rgxx3 in the name.