Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

Hello Bin,

On Fri, 13 Nov 2015 17:08:22 +0800, Bin Meng bmeng.cn@gmail.com wrote:

Hi Albert,

...

•   subl    %esp, %eax
  

I guess you are confused by the AT&T assembly syntax. This should be: subl %eax, %esp.

...

•   subl    %esp, %eax
  

Ditto.

Thanks -- last time I touched Intel assembly was more than a decade ago...

...

•   arch_setup_gd(gd_ptr);
  

This arch_setup_gd(gd_ptr) should not be deleted.

Correct.

Regards, Bin

Thanks! These fixes will go in v3.

Amicalement,