Re: [U-Boot] [PATCH 2/2] RFC: Let linker create phy array

On Saturday 04 February 2012 22:02:46 Troy Kisky wrote:

--- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c

-static struct phy_driver BCM5461S_driver = { +struct phy_driver BCM5461S_driver __phy_entry = {

why do you have to remove the static ? that shouldn't affect the section name that it gets placed into.

--- a/include/phy.h +++ b/include/phy.h

+extern struct phy_driver __phy_entry_start, __phy_entry_end;

linker symbols should be declared like: extern char __phy_entry_start[];

--- a/u-boot-common.lds +++ b/u-boot-common.lds

i'm not seeing this in the u-boot tree ...

• . = ALIGN(4);
• __phy_entry_start = .;
• .phy_entry : {

• KEEP(*(.phy_entry))
  

• }
• __phy_entry_end = .;

might have to introduce a helper macro like Linux's VMLINUX_SYMBOL() since some targets have a symbol prefix (like an underscore) -mike